linux-kernel - Re: [PATCH v2 03/26] selftests/resctrl: Refactor fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <213df261-03ee-4b13-80ac-236c2dfde09a@intel.com>
Date:   Tue, 28 Nov 2023 14:10:33 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        "Shaopeng Tan" <tan.shaopeng@...fujitsu.com>,
        Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 03/26] selftests/resctrl: Refactor fill_buf functions

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> There are unnecessary nested calls in fill_buf.c:
>   - run_fill_buf() calls fill_cache()
>   - alloc_buffer() calls malloc_and_init_memory()
> 
> Simplify the code flow and remove those unnecessary call levels by
> moving the called code inside the calling function.
> 
> Resolve the difference in run_fill_buf() and fill_cache() parameter
> name into 'buf_size' which is more descriptive than 'span'. Also, while
> moving the allocation related code, rename 'p' into 'buf' to be
> consistent in naming the variables.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette