linux-kernel - Re: [PATCH v2 13/26] selftests/resctrl: Improve perf init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1990a455-9698-4d9c-bbe1-c47fa83cb71b@intel.com>
Date:   Tue, 28 Nov 2023 14:15:32 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        "Shaopeng Tan" <tan.shaopeng@...fujitsu.com>,
        Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 13/26] selftests/resctrl: Improve perf init

Hi Ilpo,

On 11/20/2023 3:13 AM, Ilpo Järvinen wrote:
> struct perf_event_attr initialization is spread into
> perf_event_initialize() and perf_event_attr_initialize() and setting
> ->config is hardcoded by the deepest level.
> 
> perf_event_attr init belongs to perf_event_attr_initialize() so move it
> entirely there. Rename the other function
> perf_event_initialized_read_format().
> 
> Call each init function directly from the test as they will take
> different parameters (especially true after the perf related global
> variables are moved to local variables).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette