linux-kernel - Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634164b4a8085770bd06134c1d328d8b@walle.cc>
Date:   Tue, 28 Nov 2023 23:44:33 +0100
From:   Michael Walle <michael@...le.cc>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Michael Walle <mwalle@...nel.org>,
        Laurent.pinchart@...asonboard.com, andrzej.hajda@...el.com,
        dave.stevenson@...pberrypi.com, dianders@...omium.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        jernej.skrabec@...il.com, jonas@...boo.se,
        konrad.dybcio@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, marex@...x.de,
        marijn.suijten@...ainline.org, mripard@...nel.org,
        neil.armstrong@...aro.org, quic_abhinavk@...cinc.com,
        quic_jesszhan@...cinc.com, rfoss@...nel.org, sean@...rly.run,
        tzimmermann@...e.de, tony@...mide.com,
        alexander.stein@...tq-group.com
Subject: Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over
 the DSI link power state

>> I'm facing similar issues with the tc358775 bridge. This bridge needs
>> to release its reset while both clock and data lanes are in LP-11
>> mode.
>> But then it needs to be configured (via I2C) while the clock lane is
>> in enabled (HS mode), but the data lanes are still in LP-11 mode.
> 
> This is quite an interesting requirement. For example, I'm not 100%
> sure whether we can get that done on our (msm) hosts. I need to double
> check that.
> What frequency is expected on the CLK lane? Can it be an arbitrary
> frequency or it should be the same freq as the one used later for the
> video transfer?

I presume it has to be the same frequency as the video stream later.
That's a least what I have successfully tested.
The datasheet doesn't mention if a frequency switch is allowed on the
clock lane (which would need a brief switch to LP mode, I presume). I'd 
say
it's not allowed/supported as the bridge is very picky regarding the 
init
sequence in general.

I'm using the Mediatek DSI host, where that sequence is possible. I.e. 
you
just enable the clock and data lanes in continuous clock mode, but don't
enable the video stream, which should leave the data lanes in LP-11 
mode.

Sometimes you also have a command mode (instead of a video mode). And if
you don't send any commands, the data lanes are in LP-11 mode, too.

-michael

>> Therefore, for the correct init sequence is:
>> (1) dsi host enables lanes, that is clock and data are in lp-11
>> (2) dsi bridge driver releases reset of the bridge
>> (3) dsi host enables clock lane, leaves data lanes in lp-11
>> (4) dsi bridge driver configures the bridge
>> (5) dsi host enables the video stream
>> (6) dsi bridge enables the output port of the bridge