linux-kernel - RE: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bfcd8067e3f4cea815ebb768fc58b5d@EXMBX066.cuchost.com>
Date:   Tue, 28 Nov 2023 05:24:36 +0000
From:   JeeHeng Sia <jeeheng.sia@...rfivetech.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "conor@...nel.org" <conor@...nel.org>,
        "kernel@...il.dk" <kernel@...il.dk>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "emil.renner.berthing@...onical.com" 
        <emil.renner.berthing@...onical.com>
CC:     "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Leyfoon Tan <leyfoon.tan@...rfivetech.com>
Subject: RE: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, November 27, 2023 4:49 PM
> To: JeeHeng Sia <jeeheng.sia@...rfivetech.com>; paul.walmsley@...ive.com; palmer@...belt.com; aou@...s.berkeley.edu;
> conor@...nel.org; kernel@...il.dk; robh+dt@...nel.org; emil.renner.berthing@...onical.com
> Cc: linux-riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Leyfoon Tan <leyfoon.tan@...rfivetech.com>
> Subject: Re: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string
> 
> On 27/11/2023 02:36, Sia Jee Heng wrote:
> > Add starfive,jh8100-uart compatible string
> 
> Describe the hardware. Why is it in xilinx?
My bad. It should CDNS UART driver. Will fix it.
> 
> Also, missing full stop in each commit msg.
Noted.
> 
> >
> > Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> > Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> > ---
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.
Noted. Should I resend the patches with the V1 tag and with addressed comments?
> 
> Best regards,
> Krzysztof