[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <170113166294.1670814.14494797449586768583.b4-ty@chromium.org>
Date: Mon, 27 Nov 2023 16:34:27 -0800
From: Kees Cook <keescook@...omium.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Kees Cook <keescook@...omium.org>,
Alexey Dobriyan <adobriyan@...il.com>,
Will Deacon <will@...nel.org>, Kalle Valo <kvalo@...nel.org>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] uapi: propagate __struct_group() attributes to the container union
On Mon, 20 Nov 2023 14:05:08 +0300, Dmitry Antipov wrote:
> Recently the kernel test robot has reported an ARM-specific BUILD_BUG_ON()
> in an old and unmaintained wil6210 wireless driver. The problem comes from
> the structure packing rules of old ARM ABI ('-mabi=apcs-gnu'). For example,
> the following structure is packed to 18 bytes instead of 16:
>
> struct poorly_packed {
> unsigned int a;
> unsigned int b;
> unsigned short c;
> union {
> struct {
> unsigned short d;
> unsigned int e;
> } __attribute__((packed));
> struct {
> unsigned short d;
> unsigned int e;
> } __attribute__((packed)) inner;
> };
> } __attribute__((packed));
>
> [...]
Applied to for-linus/hardening, thanks!
[1/1] uapi: propagate __struct_group() attributes to the container union
https://git.kernel.org/kees/c/4e86f32a13af
Take care,
--
Kees Cook
Powered by blists - more mailing lists