linux-kernel - Re: [PATCH] perf: ignore exited thread when synthesize thread map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com>
Date:   Tue, 28 Nov 2023 14:22:47 +0800
From:   cruzzhao <cruzzhao@...ux.alibaba.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     mingo@...hat.com, peterz@...radead.org, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
        kprateek.nayak@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: ignore exited thread when synthesize thread map



在 2023/11/23 上午5:05, Namhyung Kim 写道:
> Hello,
> 
> On Tue, Nov 21, 2023 at 6:22 PM Cruz Zhao <CruzZhao@...ux.alibaba.com> wrote:
>>
>> When synthesize thread map, some threads in thread map may have
>> already exited, so that __event__synthesize_thread() returns -1
>> and the synthesis breaks. However, It will not have any effect
>> if we just ignore the exited thread. So just ignore it and continue.
> 
> Looks ok.  But I guess you want to do the same for the leader
> thread below as well.
> 
> Thanks,
> Namhyung
> 

With my testcase, no error is returned even if we don't do the same for
the leader thread blow. Well, I'll check whether the logic is still
correct if we do so.

Many thanks for reviewing.

Best,
Cruz Zhao