linux-kernel - RE: [PATCH v2] driver : edac : Fix warning using plain integer as NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2023 07:47:47 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     Abhinav Singh <singhabhinav9051571833@...il.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "bp@...en8.de" <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "rric@...nel.org" <rric@...nel.org>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] driver : edac : Fix warning using plain integer as
 NULL

> From: Abhinav Singh <singhabhinav9051571833@...il.com>
> ...
> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c index
> 08bf20c60111..4c76d0f180ec 100644
> --- a/drivers/edac/i7core_edac.c
> +++ b/drivers/edac/i7core_edac.c
> @@ -376,7 +376,7 @@ static const struct pci_id_table pci_dev_table[] = {
>  	PCI_ID_TABLE_ENTRY(pci_dev_descr_i7core_nehalem),
>  	PCI_ID_TABLE_ENTRY(pci_dev_descr_lynnfield),
>  	PCI_ID_TABLE_ENTRY(pci_dev_descr_i7core_westmere),
> -	{NULL,}			/* 0 terminated list. */
> +	{NULL,}			/* NULL terminated list. */
>  };
> 
>  /*
> @@ -385,7 +385,7 @@ static const struct pci_id_table pci_dev_table[] =
> {  static const struct pci_device_id i7core_pci_tbl[] = {
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_X58_HUB_MGMT)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_LYNNFIELD_QPI_LINK0)},
> -	{0,}			/* 0 terminated list. */
> +	{0,}			/* NULL terminated list. */
>  };

The updated comment (NULL pointer) mismatches the code (zero value).