linux-kernel - Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6342ad8a798ef811d37775b7269623a3@walle.cc>
Date:   Tue, 28 Nov 2023 09:36:27 +0100
From:   Michael Walle <michael@...le.cc>
To:     "Boyapally, Srikanth" <Srikanth.Boyapally@....com>
Cc:     Pratyush Yadav <pratyush@...nel.org>, tudor.ambarus@...aro.org,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        "git (AMD-Xilinx)" <git@....com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g

Hi,

>> > Add support for issi is25lp02g.
>> >
>> > Verified on AMD-Xilinx versal platform and executed mtd_debug
>> > read/write test.
>> >
>> > Signed-off-by: Srikanth Boyapally <srikanth.boyapally@....com>
>> 
>> Based on a datasheet [0] I found online, this flash seems to have 
>> SFDP.
>> And since you do not add any flash specific fixups, it likely does not 
>> need an entry
>> and would work fine with the generic flash driver. Did you try using 
>> that? See [1]
>> for more info on contribution guidelines.
>> 
>> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
>> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
>> tudor.ambarus@...aro.org/
>> 
> I ran mtd_debug read/write tests on this flash, without adding flash
> entry, it worked fine for me. Please ignore this patch.

Great! Could you please still dump and post your SFDP just for us to
have more SFDP of diferent flashes? See [1].

-michael