linux-kernel - Re: [PATCH 0/2] freezer,sched: do not restore saved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a86228f5-c1ae-4afe-87bd-5144633a9601@quicinc.com>
Date:   Tue, 28 Nov 2023 17:12:00 +0800
From:   "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com>
To:     Elliot Berman <quic_eberman@...cinc.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Ingo Molnar <mingo@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
CC:     <linux-arm-msm@...r.kernel.org>,
        Pavan Kondeti <quic_pkondeti@...cinc.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Abhijeet Dharmapurikar <quic_adharmap@...cinc.com>
Subject: Re: [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed
 task

On 11/21/2023 1:36 AM, Elliot Berman wrote:
> This series applies couple fixes to commit 8f0eed4a78a8 ("freezer,sched:
> Use saved_state to reduce some spurious wakeups") which was found while
> testing with legacy cgroup freezer. My original testing was only with
> system-wide freezer. We found that thaw_task could be called on a task
> which was already frozen. Prior to commit 8f0eed4a78a8 ("freezer,sched:
> Use saved_state to reduce some spurious wakeups"), this wasn't an issue
> as kernel would try to wake up TASK_FROZEN, which wouldn't match the
> thawed task state, and no harm done to task. After commit 8f0eed4a78a8
> ("freezer,sched: Use saved_state to reduce some spurious wakeups"), it
> was possible to overwrite the state of thawed task.
> 
> To: Rafael J. Wysocki <rafael@...nel.org>
> To: Pavel Machek <pavel@....cz>
> To: Ingo Molnar <mingo@...nel.org>
> To: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc:  <linux-arm-msm@...r.kernel.org>
> Cc: Pavan Kondeti <quic_pkondeti@...cinc.com>
> Cc: Aiqun Yu (Maria) <quic_aiquny@...cinc.com>
> Cc:  <linux-pm@...r.kernel.org>
> Cc:  <linux-kernel@...r.kernel.org>
> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
Shall we add Fixed tag and Cc: stable@...r.kernel.org ?
Since it is fixing a stable user thread hung issue.
> 
> Originally sent to only linux-arm-msm, resending to correct authors.
> - Link to v1: https://lore.kernel.org/r/20231120-freezer-state-multiple-thaws-v1-0-a4c453f50745@quicinc.com
> 
> ---
> Elliot Berman (2):
>        freezer,sched: do not restore saved_state of a thawed task
>        freezer,sched: clean saved_state when restoring it during thaw
> 
>   kernel/freezer.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> ---
> base-commit: 6d7e4782bcf549221b4ccfffec2cf4d1a473f1a3
> change-id: 20231108-freezer-state-multiple-thaws-7a3a8d9dadb3
> 
> Best regards,

-- 
Thx and BRs,
Aiqun(Maria) Yu