linux-kernel - Re: [PATCH 3/3] riscv: dts: sophgo: add rtc dt node for CV1800B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJRtX8Skn7y_=Zq9U0mk0msVAkQ0-EAvofzkmC-ZEA_Q8XLxgA@mail.gmail.com>
Date:   Tue, 28 Nov 2023 21:23:04 +0800
From:   jingbao qiu <qiujingbao.dlmu@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, chao.wei@...hgo.com,
        unicorn_wang@...look.com, conor+dt@...nel.org, robh+dt@...nel.org,
        conor@...nel.org, paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] riscv: dts: sophgo: add rtc dt node for CV1800B

On Tue, Nov 21, 2023 at 6:00 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 21/11/2023 10:46, Jingbao Qiu wrote:
> > Add the rtc device tree node to CV1800B SoC.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> > ---
> >  arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > index df40e87ee063..89411c75b89a 100644
> > --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > @@ -119,5 +119,13 @@ clint: timer@...00000 {
> >                       reg = <0x74000000 0x10000>;
> >                       interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>;
> >               };
> > +
> > +             rtc: rtc-controller@...26000 {
> > +                     compatible = "sophgo,cv800b-rtc";
> > +                     reg = <0x05026000 0x1000>;
> > +                     interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> > +                     interrupt-parent = <&plic>;
> > +                     clocks = <&osc>;
> > +             };
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

I will check it.

>
> Best regards,
> Krzysztof
>

Best regards,
Jingbao Qiu