linux-kernel - Re: [PATCH] powercap: DTPM: Fix unneeded conversion to micro-Watts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <95757bf5-a7c3-48ac-86b8-62e28680d903@arm.com>
Date:   Tue, 28 Nov 2023 14:24:39 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        daniel.lezcano@...aro.org, stable@...r.kernel.org
Subject: Re: [PATCH] powercap: DTPM: Fix unneeded conversion to micro-Watts



On 11/28/23 14:17, Rafael J. Wysocki wrote:
> On Mon, Nov 27, 2023 at 10:27 AM Lukasz Luba <lukasz.luba@....com> wrote:
>>
>> The Power values coming from the Energy Model are already in uW.
>> The PowerCap and DTPM framework operate on uW, thus all places should
>> just use the values from EM. Fix the code which left and still does
>> the unneeded conversion.
>>
>> Fixes: ae6ccaa65038 (PM: EM: convert power field to micro-Watts precision and align drivers)
>> Cc: <stable@...r.kernel.org> # v5.19+
>> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
>> ---
>> Hi Daniel,
>>
>> I have found an issue due to the uW in the EM. My apologies for that.
> 
> No need to apologize, you are making the code better.

I apologize because I introduced this uW change in the EM fwk :)
although I missed those DTPM bits which are now fixed.

Daniel told me last week that I can easily test the DTPM using
the rockpi code (because it was a pain for me in some hacks
trying to test DTPM).

> 
>> I have check those with the Rockpi dev board with your DTPM module there.
>> BTW, if you like to check the DTPM_devfreq there, you can apply that
>> patch. It should create EM for your GPU there and setup DTPM GPU:
>> https://lore.kernel.org/all/20231127081511.1911706-1-lukasz.luba@arm.com/
>>

[snip]

> 
> Applied as 6.7-rc material, thanks!

thanks Rafael!