lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 28 Nov 2023 23:19:55 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Patrick Georgi <pgeorgi@...gle.com>, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, Stefan Reinauer <reinauer@...gle.com>
Subject: Re: [PATCH] kconfig: WERROR unmet symbol dependency

On Tue, Nov 28, 2023 at 2:34 PM Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> On (23/11/22 12:47), Sergey Senozhatsky wrote:
> > When KCONFIG_WERROR env variable is set treat unmet direct
> > symbol dependency as a terminal condition (error).
> >
> > Suggested-by: Stefan Reinauer <reinauer@...gle.com>
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>
>
> Gentle ping.


I believe you know this patch is too cheesy to be accepted.



KCONFIG_WERROR is meant to turn all warnings
to errors.

I do not see getenv("KCONFIG_WERROR")
sprinkled everywhere in Kconfig.



One more thing, you cannot directly exit(1)
from sym_calc_value().

Curses programs (menuconfig / nconfig),
must call endwin() before exiting.

Otherwise, the terminal will not come back
to the canonical mode.


You do not need to fix it, though.








--
Best Regards
Masahiro Yamada

Powered by blists - more mailing lists