linux-kernel - Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2023 22:34:22 +0800
From:   jingbao qiu <qiujingbao.dlmu@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, chao.wei@...hgo.com,
        unicorn_wang@...look.com, conor+dt@...nel.org, robh+dt@...nel.org,
        conor@...nel.org, paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC

On Tue, Nov 28, 2023 at 9:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 28/11/2023 14:22, jingbao qiu wrote:
> >>> +     if (ret)
> >>> +             goto err;
> >>> +
> >>> +     rtc->clk = devm_clk_get(&pdev->dev, NULL);
> >>> +     if (IS_ERR(rtc->clk)) {
> >>> +             dev_err(&pdev->dev, "no clock");
> >>
> >> This code is not ready for upstream. There are multiple things wrong here.
> >>
> >> First, syntax is return dev_err_probe.
> >>
> >> Second, you do not have clocks and you do not allow them! Just open your
> >> binding.
> >
> > I'm not fully understanding here, can you elaborate more?
>
> That the syntax is dev_err_probe() or that you do not have clocks?
>
>
> > as there is clocks info like this in the dt-bindings:
> >  clocks = <&osc>;
>
> Really?
>
> Point me to the line in your patch:
>
> +properties:
> +  compatible:
> +    enum:
> +      - sophgo,cv1800b-rtc
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
>
> Where are the clocks?

I will fix properties.

>
>
> Best regards,
> Krzysztof
>

Best regards,
Jingbao Qiu