[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231129-crawling-gaming-76077ed03c57@spud>
Date: Wed, 29 Nov 2023 15:38:04 +0000
From: Conor Dooley <conor@...nel.org>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
Santosh Shilimkar <ssantosh@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Vignesh Raghavendra <vigneshr@...com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
gregory.clement@...tlin.com, u-kumar1@...com
Subject: Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci
compatible
On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote:
> On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote:
> > On j7200, during suspend to ram the soc is powered-off.
> > At resume requested irqs shall be restored which is a different behavior
> > from other platforms.
> >
> > Signed-off-by: Thomas Richard <thomas.richard@...tlin.com>
>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Un-Acked. Your dts patch contradicts this one.
Is the programming model compatible with the existing devices? To be
compatible, the existing device only need to support a compatible subset
of behaviours.
If so, this patch is wrong. If not, then the dts one is.
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists