linux-kernel - RE: [PATCH] intel_idle: add Cometlake support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001701da22db$180872c0$48195840$@telus.net>
Date:   Wed, 29 Nov 2023 07:45:34 -0800
From:   "Doug Smythies" <dsmythies@...us.net>
To:     "'Rafael J. Wysocki'" <rafael@...nel.org>,
        "'Jiang Yihe'" <jiangyihe042@...il.com>
Cc:     "'Jacob Pan'" <jacob.jun.pan@...ux.intel.com>,
        "'Len Brown'" <lenb@...nel.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "'Zhang, Rui'" <rui.zhang@...el.com>,
        "'Artem Bityutskiy'" <artem.bityutskiy@...ux.intel.com>,
        "Doug Smythies" <dsmythies@...us.net>
Subject: RE: [PATCH] intel_idle: add Cometlake support

Hi All,

This proposed patch has been submitted at least once before.
(I think more than once, but only found 1)
Reference:
https://lore.kernel.org/linux-pm/20200227013411.1.Ica3bb9fa898499d94e0b0a2bfa08ec46c89d84fa@changeid/

I have a Cometlake processor and am not in favor of this patch.
Reference at to why not:
https://bugzilla.kernel.org/show_bug.cgi?id=210741

... Doug

On 2023.11.29 07:19 Rafael wrote:
> +Rui and Artem
>On Wed, Nov 29, 2023 at 3:32 PM Jiang Yihe <jiangyihe042@...il.com> wrote:
>>
>> Since the Cometlake C-State is supported, support for Cometlake should
>> be added to intel_idle. Just use Kabylake C-State table for Cometlake
>> because they share the same table in intel_cstate.
>>
>> Signed-off-by: Jiang Yihe <jiangyihe042@...il.com>
>> ---
>>  drivers/idle/intel_idle.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>> index dcda0afec..f83f78037 100644
>> --- a/drivers/idle/intel_idle.c
>> +++ b/drivers/idle/intel_idle.c
>> @@ -1418,6 +1418,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>>         X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE,             &idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L,          &idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE,            &idle_cpu_skl),
>> +       X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L,         &idle_cpu_skl),
>> +       X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE,           &idle_cpu_skl),
>>         X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X,           &idle_cpu_skx),
>>         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X,           &idle_cpu_icx),
>>         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D,           &idle_cpu_icx),
>> --