lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <PH0PR18MB4734BE1829B78CB772EDD299C783A@PH0PR18MB4734.namprd18.prod.outlook.com>
Date:   Wed, 29 Nov 2023 04:42:15 +0000
From:   Shinas Rasheed <srasheed@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani <hgani@...vell.com>,
        Vimlesh Kumar <vimleshk@...vell.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Sathesh B Edara <sedara@...vell.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v1 1/2] octeon_ep: implement device
 unload control net API



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, November 29, 2023 3:25 AM
> To: Shinas Rasheed <srasheed@...vell.com>
> >+	dev_info(&oct->pdev->dev, "Sending dev_unload msg to fw\n");
> 
> Is it really necessary to print this at info level for each remove?
> Remove is a normal part of operation and we shouldn't spam logs
> unless we have a good reason..

I suppose it's not a need other than maybe for debug purposes. I'll use dev_dbg and submit a second version

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ