linux-kernel - Re: 回复: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87cyvs5ulu.fsf@intel.com>
Date:   Wed, 29 Nov 2023 19:37:17 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     何敏红 <heminhong@...inos.cn>,
        "ville.syrjala" <ville.syrjala@...ux.intel.com>,
        "uma.shankar" <uma.shankar@...el.com>
Cc:     airlied <airlied@...il.com>,
        "animesh.manna" <animesh.manna@...el.com>,
        "ankit.k.nautiyal" <ankit.k.nautiyal@...el.com>,
        daniel <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        "joonas.lahtinen" <joonas.lahtinen@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "rodrigo.vivi" <rodrigo.vivi@...el.com>,
        "tvrtko.ursulin" <tvrtko.ursulin@...ux.intel.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: 回复: [PATCH v2] drm/i915: correct the input
 parameter on
 _intel_dsb_commit()

On Wed, 29 Nov 2023, 何敏红 <heminhong@...inos.cn> wrote:
> Friendly ping. I think this patch was forgotten.

Pushed, thanks for the patch.

>
> ----
>
> 主　题：[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit() 
> 日　期：2023-11-14 10:43 
> 发件人：何敏红 
> 收件人：何敏红;
>
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot 
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
> Cc: Ville Syrjälä 
> Cc: Uma Shankar 
>
> Signed-off-by: heminhong 
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);

-- 
Jani Nikula, Intel