linux-kernel - Re: [PATCH 4.14 00/53] 4.14.331-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZWd4v-7Qnc2gde5L@sashalap>
Date:   Wed, 29 Nov 2023 12:45:35 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        stable@...r.kernel.org, patches@...ts.linux.dev,
        LKML <linux-kernel@...r.kernel.org>,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
        allen.lkml@...il.com, alexander.deucher@....com,
        mario.limonciello@....com, zhujun2@...s.chinamobile.com,
        skhan@...uxfoundation.org, bhelgaas@...gle.com
Subject: Re: [PATCH 4.14 00/53] 4.14.331-rc2 review

On Wed, Nov 29, 2023 at 10:00:44AM +0100, Pavel Machek wrote:
>On Tue 2023-11-28 21:10:03, Greg Kroah-Hartman wrote:
>> On Tue, Nov 28, 2023 at 09:48:42PM +0100, Pavel Machek wrote:
>> > Hi!
>> >
>> > > > > > > Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>> > > > > > >     RDMA/hfi1: Use FIELD_GET() to extract Link Width
>> > > > > >
>> > > > > > This is a good cleanup, but not a bugfix.
>> > > > > >
>> > > > > > > Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>> > > > > > >     atm: iphase: Do PCI error checks on own line
>> > > > > >
>> > > > > > Just a cleanup, not sure why it was picked for stable.
>> > > > >
>> > > > > Just an additional bit of information, there have been quite many cleanups
>> > > > > from me which have recently gotten the stable notification for some
>> > > > > mysterious reason. When I had tens of them in my inbox and for various
>> > > > > kernel versions, I immediately stopped caring to stop it from happening.
>> > > > >
>> > > > > AFAIK, I've not marked those for stable inclusion so I've no idea what
>> > > > > got them included.
>> > > >
>> > > > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
>> > > > human oversight :-(.
>> > >
>> > > the autosel bot has lots of oversight.
>> >
>> > Can you describe how that oversight works?
>>
>> There have been many papers and presentations about it, no need for me
>> to say it all here again...
>
>Give a pointer.
>
>And explain why AUTOSEL is full of cleanups, as noticed by Ilpo, me
>and others. AFAICT Sasha does not hand-check patches picked by
>AUTOSEL, simply spams the mailing lists, and hopes that maintainers
>will react. And they won't, because they don't understand the

Awesome feedback, thanks.

>implications, and simply ignore the spam. Or they will, and Sasha
>simply ignores the reply.

Incorrect, I just gotten tired of litigating this with *you*.

How about this: instead of complaining about work you get for free, try
doing it yourself and send us a list of patches that should go into the
-stable tree during the next merge window. Deal?

-- 
Thanks,
Sasha