linux-kernel - Re: [PATCH] lib: kstrtox: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e000502-d400-420c-a9f8-40e202a95271@infradead.org>
Date:   Tue, 28 Nov 2023 21:40:13 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wilken Gottwalt <wilken.gottwalt@...teo.net>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib: kstrtox: fix typo in comment



On 11/28/23 20:48, Wilken Gottwalt wrote:
> On Tue, 28 Nov 2023 08:26:03 -0800
> Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> On 11/28/23 00:27, Wilken Gottwalt wrote:
>>> Delete one of the double f's in "iff".
>>>
>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@...teo.net>
>>
>> Nope, see:
>>   https://en.wikipedia.org/wiki/If_and_only_if
> 
> Oh, interesting. Never thought of this. Though, now I wonder: How often do such
> "fixes" happen?

I think that I have seen 2 other patches for "iff", but I probably have missed some.



>>> ---
>>>  lib/kstrtox.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
>>> index d586e6af5e5a..b0a9fdce15b3 100644
>>> --- a/lib/kstrtox.c
>>> +++ b/lib/kstrtox.c
>>> @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
>>>   * @s: input string
>>>   * @res: result
>>>   *
>>> - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
>>> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
>>>   * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL.  Value
>>>   * pointed to by res is updated upon finding a match.
>>>   */
>>
> 

-- 
~Randy