linux-kernel - Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231129151030.24b807f1d2b43be301a533b7@linux-foundation.org>
Date:   Wed, 29 Nov 2023 15:10:30 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Stephen Rothwell" <sfr@...hwell.id.au>,
        linux-next <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "David S. Miller" <davem@...emloft.net>,
        sparclinux@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: linux-next: lots of errors/warnings from the
 -Werror=missing-prototypes addition

On Wed, 29 Nov 2023 23:51:04 +0100 "Arnd Bergmann" <arnd@...db.de> wrote:

> I did all my testing with CONFIG_WERROR force-enabled, so
> the bit I missed here is that at least three architectures
> that are missing fixes also set -Werror: mips, sparc and alpha.
> 
> How about adding a patch to no longer force -Werror for
> these?

These architectures are doing it wrong, aren't they?  They should be
using the CONFIG_WERROR infrastructure rather than hard-coding it?  If
so then sure, a standalone patch to clean that up sounds sounds
appropriate.  I guess it should precede "Makefile.extrawarn: turn on
missing-prototypes globally".