linux-kernel - Re: [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231129232028.nvcucoapxe4fhraw@zenone.zhora.eu>
Date:   Thu, 30 Nov 2023 00:20:28 +0100
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@....com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v4 24/24] i2c: designware: Fix spelling and other issues
 in the comments

Hi Andy,

[...]

> @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
>  {
>  	mutex_lock(&psp_i2c_access_mutex);
>  
> -	/* Return early if mailbox was malfunctional */
> +	/* Return early if mailbox was malfunctioned */

has malfunctioned?

>  	if (psp_i2c_mbox_fail)
>  		goto cleanup;
>  
>  	/*
> -	 * If we are last owner of PSP semaphore, need to release aribtration
> +	 * If we are last owner of PSP semaphore, need to release arbitration
>  	 * via mailbox.
>  	 */

as we are at this, perhaps we can add some articles and pronouns
to improve the grammar:

	/*
	 * If we are the last owner of the PSP semaphore, we need to release
	 * arbitration via the mailbox
	 */

Rest looks good.

Thanks,
Andi