linux-kernel - Re: [PATCH v2] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2023 07:53:28 +0000
From:   Wenbin Mei (梅文彬) 
        <Wenbin.Mei@...iatek.com>
To:     "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "treapking@...omium.org" <treapking@...omium.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        Chaotian Jing (井朝天) 
        <Chaotian.Jing@...iatek.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "ot_shunxi.zhang@...iatek.corp-partner.google.com" 
        <ot_shunxi.zhang@...iatek.corp-partner.google.com>
Subject: Re: [PATCH v2] mmc: mtk-sd: Increase the verbosity of
 msdc_track_cmd_data

On Wed, 2023-11-29 at 10:59 +0800, Pin-yen Lin wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  This log message is necessary for debugging, so enable it by default
> to
> debug issues that are hard to reproduce locally.
> 
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> 
> ---
> 
> Changes in v2:
> - Use dev_warn() instead of dev_err()
> 
>  drivers/mmc/host/mtk-sd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..907c13d746c1 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1150,8 +1150,8 @@ static void msdc_recheck_sdio_irq(struct
> msdc_host *host)
>  static void msdc_track_cmd_data(struct msdc_host *host, struct
> mmc_command *cmd)
>  {
>  	if (host->error)
> -		dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> -			__func__, cmd->opcode, cmd->arg, host->error);
> +		dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> +			 __func__, cmd->opcode, cmd->arg, host->error);


Hi Pin-yen,

Thanks for your changes!
Indeed, these logs are necessary for us to debug, but the crc errors
during the tuning process
are expected and we don't want them to be printed.
The timeout errors during the tuning process are unexpected and should
be printed.

So we can change it as below:
if (host->error) {
        if ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
            cmd->error == -ETIMEDOUT) {
                dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
>error=0x%08X\n", __func__, cmd->opcode, cmd->arg, host->error);
        }
}

Best regards,
Wenbin

>  }
>  
>  static void msdc_request_done(struct msdc_host *host, struct
> mmc_request *mrq)
> -- 
> 2.43.0.rc1.413.gea7ed67945-goog
>