linux-kernel - Re: [PATCH v1 1/5] mm/rmap: rename hugepage_add* to hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D65284E8-7201-4D20-B7B6-06E9AB9DD9F1@linux.dev>
Date:   Wed, 29 Nov 2023 16:42:41 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     David Hildenbrand <david@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux-MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH v1 1/5] mm/rmap: rename hugepage_add* to hugetlb_add*



> On Nov 28, 2023, at 22:52, David Hildenbrand <david@...hat.com> wrote:
> 
> Let's just call it "hugetlb_".
> 
> Yes, it's all already inconsistent and confusing because we have a lot
> of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly
> be confused with transparent huge pages, and it matches "hugetlb.c" and
> "folio_test_hugetlb()". So let's minimize confusion in rmap code.
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.