linux-kernel - Re: [PATCH v1 1/1] units: Add missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org>
Date:   Tue, 28 Nov 2023 18:09:57 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Damian Muszynski <damian.muszynski@...el.com>,
        linux-kernel@...r.kernel.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH v1 1/1] units: Add missing header

On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> BITS_PER_BYTE is defined in bits.h.
> 
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")

This is post-6.6, so the fix should go into this -rc whatever happens, but...

It would be rather nice to know the effects of this change please.  Did
some build break?

> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
>  
> +#include <linux/bits.h>
>  #include <linux/math.h>
>  
>  /* Metric prefixes in accordance with Système international (d'unités) */
> -- 
> 2.43.0.rc1.1.gbec44491f096