linux-kernel - Re: btrfs: super.c:416:25: error: 'ret' undeclared (first use in this function); did you mean 'net'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWcLTJB8wrLUwuVf@archie.me>
Date:   Wed, 29 Nov 2023 16:58:36 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        lkft-triage@...ts.linaro.org,
        Linux Regressions <regressions@...ts.linux.dev>,
        Linux btrfs <linux-btrfs@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, Chris Mason <clm@...com>,
        Anders Roxell <anders.roxell@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: btrfs: super.c:416:25: error: 'ret' undeclared (first use in
 this function); did you mean 'net'?

On Wed, Nov 29, 2023 at 02:29:42PM +0530, Naresh Kamboju wrote:
> On Wed, 29 Nov 2023 at 12:38, Bagas Sanjaya <bagasdotme@...il.com> wrote:
> >
> > On Tue, Nov 28, 2023 at 05:55:51PM +0530, Naresh Kamboju wrote:
> > > Following x86 and i386 build regressions noticed on Linux next-20231128 tag.
> > >
> > > Build log:
> > > -----------
> > > fs/btrfs/super.c: In function 'btrfs_parse_param':
> > > fs/btrfs/super.c:416:25: error: 'ret' undeclared (first use in this
> > > function); did you mean 'net'?
> > >   416 |                         ret = -EINVAL;
> > >       |                         ^~~
> > >       |                         net
> > > fs/btrfs/super.c:416:25: note: each undeclared identifier is reported
> > > only once for each function it appears in
> > > fs/btrfs/super.c:417:25: error: label 'out' used but not defined
> > >   417 |                         goto out;
> > >       |                         ^~~~
> > > make[5]: *** [scripts/Makefile.build:243: fs/btrfs/super.o] Error 1
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> > >
> > > Links:
> > >  - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231128/testrun/21349057/suite/build/test/gcc-13-lkftconfig-kselftest/log
> > >
> > >  - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231128/testrun/21349057/suite/build/test/gcc-13-lkftconfig-kselftest/details/
> > >  - https://storage.tuxsuite.com/public/linaro/lkft/builds/2Ymoxor9n54ID51BFjRBS06YQ3U/
> > > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2Ymoxor9n54ID51BFjRBS06YQ3U/config
> > >
> >
> > Is it W=1 build? I can't reproduce on btrfs tree with
> > CONFIG_BTRFS_FS_POSIX_ACL=y and without W=1.
> 
> My config did not set this
> # CONFIG_BTRFS_FS_POSIX_ACL is not set

OK.

> 
> Do you think the system should auto select the above config as default when
> following config gets enabled ?
> 
> CONFIG_BTRFS_FS=m
> (or)
> CONFIG_BTRFS_FS=y
> 

Nope, leave it as is.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)