linux-kernel - RE: [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f5648c3dbaa4f7ba2c600c125e0837a@EXMBX066.cuchost.com>
Date:   Wed, 29 Nov 2023 10:35:20 +0000
From:   JeeHeng Sia <jeeheng.sia@...rfivetech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "kernel@...il.dk" <kernel@...il.dk>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "conor@...nel.org" <conor@...nel.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "michal.simek@....com" <michal.simek@....com>,
        Michael Zhu <michael.zhu@...rfivetech.com>,
        "drew@...gleboard.org" <drew@...gleboard.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Leyfoon Tan <leyfoon.tan@...rfivetech.com>
Subject: RE: [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, November 29, 2023 4:27 PM
> To: JeeHeng Sia <jeeheng.sia@...rfivetech.com>; kernel@...il.dk; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> krzk@...nel.org; conor+dt@...nel.org; paul.walmsley@...ive.com; palmer@...belt.com; aou@...s.berkeley.edu;
> daniel.lezcano@...aro.org; tglx@...utronix.de; conor@...nel.org; anup@...infault.org; gregkh@...uxfoundation.org;
> jirislaby@...nel.org; michal.simek@....com; Michael Zhu <michael.zhu@...rfivetech.com>; drew@...gleboard.org
> Cc: devicetree@...r.kernel.org; linux-riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Leyfoon Tan
> <leyfoon.tan@...rfivetech.com>
> Subject: Re: [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC
> 
> On 29/11/2023 07:00, Sia Jee Heng wrote:
> > Add device tree bindings for the StarFive JH8100 RISC-V SoC.
> >
> > Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> > Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> > ---
> >  Documentation/devicetree/bindings/riscv/starfive.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > index cc4d92f0a1bf..7e2da9eef3db 100644
> > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > @@ -29,7 +29,10 @@ properties:
> >                - starfive,visionfive-2-v1.2a
> >                - starfive,visionfive-2-v1.3b
> >            - const: starfive,jh7110
> > -
> > +      - items:
> > +          - enum:
> > +              - starfive,jh8100-evb
> > +          - const: starfive,jh8100
> 
> Why did you remove the blank line? No need for doing that.
Noted. Will fix it.
> 
> >  additionalProperties: true
> >
> >  ...
> 
> Best regards,
> Krzysztof