lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <SJ0PR11MB58964B3A97175826216EA8D7C383A@SJ0PR11MB5896.namprd11.prod.outlook.com> Date: Wed, 29 Nov 2023 02:27:05 +0000 From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com> To: Artem Chernyshev <artem.chernyshev@...-soft.ru>, "Satish Kharat (satishkh)" <satishkh@...co.com>, "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com> CC: "James E . J . Bottomley" <jejb@...ux.ibm.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org> Subject: RE: [PATCH] scsi: fnic: return error if vmalloc failed On Tuesday, November 28, 2023 3:10 AM, Artem Chernyshev <artem.chernyshev@...-soft.ru> wrote: > > In fnic_init_module() exists redundant check for return value from fnic_debugfs_init(), because at moment it only can return zero. It make sense to process theoretical vmalloc failure. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 9730ddfb123d ("scsi: fnic: remove redundant assignment of variable rc") > Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru> > --- > drivers/scsi/fnic/fnic_debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c > index c4d9ed0d7d75..cf2601bf170a 100644 > --- a/drivers/scsi/fnic/fnic_debugfs.c > +++ b/drivers/scsi/fnic/fnic_debugfs.c > @@ -52,9 +52,10 @@ int fnic_debugfs_init(void) > fc_trc_flag->fnic_trace = 2; > fc_trc_flag->fc_trace = 3; > fc_trc_flag->fc_clear = 4; > + return 0; > } > > - return 0; > + return -ENOMEM; > } > > /* > -- > 2.37.3 Looks good to me. Reviewed-by: Karan Tilak Kumar <kartilak@...co.com> Regards, Karan
Powered by blists - more mailing lists