linux-kernel - Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d4d42b22-076b-4980-aa43-d5458a094873@app.fastmail.com>
Date:   Wed, 29 Nov 2023 13:04:53 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Donald Robson" <Donald.Robson@...tec.com>,
        "Frank Binns" <Frank.Binns@...tec.com>,
        "Matt Coster" <Matt.Coster@...tec.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Thomas Zimmermann" <tzimmermann@...e.de>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Dave Airlie" <airlied@...il.com>,
        "Sarah Walker" <Sarah.Walker@...tec.com>,
        "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "Maxime Ripard" <mripard@...nel.org>
Subject: Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote:
> Hello Arnd,
>
> Thanks for the patch.  I'm slightly concerned that we've not seen this 
> warning when
> building here.  I guess we need to check our CI settings...
>
> Reviewed-by: Donald Robson <donald.robson@...tec.com>

This was previously enabled only when building with either
"make W=1" or "make C=1", but not the default build, which
explains why it only showed up after the merge into linux-next
that has the corresponding scripts/Makefile.extrawarn change.

It would still be a good idea to add the extra compiler (W=1)
and sparse (C=1) warnings in your CI system and address all
other issues that might uncover.

      Arnd