linux-kernel - Re: [PATCH v5] PM: sleep: Expose last succeeded resumed timestamp in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231129221830.05ee995bfd0f5337dd0fb4d1@kernel.org>
Date:   Wed, 29 Nov 2023 22:18:30 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        suleiman@...gle.com, briannorris@...gle.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v5] PM: sleep: Expose last succeeded resumed timestamp
 in sysfs

Hi Randy,

On Mon, 27 Nov 2023 15:47:01 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> Hi--
> 
> 
> On 11/27/23 02:38, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu <mhiramat@...nel.org>
> > 
> 
> > diff --git a/kernel/power/main.c b/kernel/power/main.c
> > index f6425ae3e8b0..2ab23fd3daac 100644
> > --- a/kernel/power/main.c
> > +++ b/kernel/power/main.c
> 
> > @@ -514,6 +526,9 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
> >  			suspend_step_name(
> >  				suspend_stats.failed_steps[index]));
> >  	}
> > +	seq_printf(s,	"last_success_resume_time:\t%-llu.%llu\n",
> 
> The <TAB> after "s," is a bit odd IMO, but I don't see a need to resend it
> just for that.

Yeah, this might be a cosmetic tab. You can see the other seq_prints()
in the same function also have the same <TAB>. I don't want to break it.

Thank you,

> 
> > +		   (unsigned long long)suspend_stats.last_success_resume_time.tv_sec,
> > +		   (unsigned long long)suspend_stats.last_success_resume_time.tv_nsec);
> >  
> >  	return 0;
> >  }
> 
> -- 
> ~Randy


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>