[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231129-haste-emperor-3a8ba335b267@spud>
Date: Wed, 29 Nov 2023 14:23:32 +0000
From: Conor Dooley <conor@...nel.org>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Andi Shyti <andi.shyti@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Pierre-Yves MORDRET <pierre-yves.mordret@...s.st.com>,
linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] dt-bindings: i2c: document st,stm32mp25-i2c
compatible
On Wed, Nov 29, 2023 at 01:59:12PM +0100, Alain Volmat wrote:
> Add a new compatible st,stm32mp25-i2c for the STM32MP25 series which
> has only one interrupt line for both events and errors and differs in
> term of handling of FastModePlus.
>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
> .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 49 +++++++++++++++----
> 1 file changed, 39 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> index 94b75d9f66cd..6a69bb6de23e 100644
> --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> @@ -19,6 +19,7 @@ allOf:
> - st,stm32f7-i2c
> - st,stm32mp13-i2c
> - st,stm32mp15-i2c
> + - st,stm32mp25-i2c
> then:
> properties:
> i2c-scl-rising-time-ns:
> @@ -41,6 +42,43 @@ allOf:
> clock-frequency:
> enum: [100000, 400000]
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - st,stm32f4-i2c
> + - st,stm32f7-i2c
> + - st,stm32mp13-i2c
> + - st,stm32mp15-i2c
> + then:
> + properties:
> + interrupts:
> + items:
> + - description: interrupt ID for I2C event
> + - description: interrupt ID for I2C error
> +
> + interrupt-names:
> + items:
> + - const: event
> + - const: error
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - st,stm32mp25-i2c
> + then:
Should this not just be "else:"?
> + properties:
> + interrupts:
> + items:
> + - description: common interrupt for events and errors
> +
> + interrupt-names:
> + items:
> + - const: event
> +
Cheers,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists