linux-kernel - Re: [PATCH] scripts/show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nS9_uPXNXc6mORtWsBEUB7JBWeUW+aAQ0Osqnca3vaVA@mail.gmail.com>
Date:   Thu, 30 Nov 2023 18:13:42 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Hu Haowen <2023002089@...k.tyut.edu.cn>
Cc:     gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        masahiroy@...nel.org, ndesaulniers@...gle.com, n.schier@....de,
        ojeda@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/show_delta: reformat code

On Thu, Nov 30, 2023 at 3:49 PM Hu Haowen <2023002089@...k.tyut.edu.cn> wrote:
>
> -                               if string.find(rest, base_str)==1:
> +                               if string.find(rest, base_str) == 1:

If this is changed, shouldn't be others like:

>                 if arg=="-b":
>                 elif arg=="-h":

be changed too?

In other words, it seems this was done manually. Should we instead
introduce/use something like Black or Ruff if we are going to do this
sort of changes?

Thanks!

Cheers,
Miguel