linux-kernel - Re: linux-next: Tree for Nov 30 (mm/zswap.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=NCzMQzJxOTOsOZzGe4TeC6hzEUaw1HGHQLCc2bBTisNg@mail.gmail.com>
Date:   Thu, 30 Nov 2023 10:51:56 -0800
From:   Nhat Pham <nphamcs@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>,
        Seth Jennings <sjenning@...hat.com>,
        Dan Streetman <ddstreet@...e.org>,
        Vitaly Wool <vitaly.wool@...sulko.com>
Subject: Re: linux-next: Tree for Nov 30 (mm/zswap.c)

On Thu, Nov 30, 2023 at 9:16 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 11/29/23 19:03, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231129:
> >
>
> on i386, loongarch, ppc64, riscv32:
> when CONFIG_MEMCG is not set.
>
>
> ../mm/zswap.c: In function 'mem_cgroup_from_entry':
> ../mm/zswap.c:313:31: error: implicit declaration of function 'obj_cgroup_memcg'; did you mean 'obj_cgroup_put'? [-Werror=implicit-function-declaration]
>   313 |         return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
>       |                               ^~~~~~~~~~~~~~~~
>       |                               obj_cgroup_put
> ../mm/zswap.c:313:62: warning: pointer/integer type mismatch in conditional expression
>   313 |         return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
>       |                                                              ^
> ../mm/zswap.c: In function 'shrink_worker':
> ../mm/zswap.c:984:31: error: invalid use of undefined type 'struct mem_cgroup'
>   984 |                 css_get(&memcg->css);
>       |                               ^~
>
>
>
> --
> ~Randy
>

Thanks for the report, Randy! I'm fixing this for the !CONFIG_MEMCG
case. A new version of this patch series should be sent out in a short
while.