linux-kernel - Re: [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231130201454.jhh72rmrf6bumw2x@bogus>
Date:   Thu, 30 Nov 2023 20:14:54 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Sibi Sankar <quic_sibis@...cinc.com>
Cc:     Cristian Marussi <cristian.marussi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_mdtipton@...cinc.com, linux-arm-kernel@...ts.infradead.org,
        quic_asartor@...cinc.com, quic_lingutla@...cinc.com
Subject: Re: [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the
 perf protocol

On Fri, Dec 01, 2023 at 01:02:25AM +0530, Sibi Sankar wrote:
>
> On 11/30/23 21:55, Cristian Marussi wrote:
> >
> > Ah right
> >
> >     freq *= dom->multi_fact;
> >
> > does the trick..but cannot this by itself (under unplausibl conds)
> > overflow and does not fit into a u32 mult_factor ?
> >
> >   dom_info->mult_factor =
> >   	(dom_info->sustained_freq_khz * 1000UL)
>
> wouldn't having the 1000UL ensure that we don't truncate though?

Correct but the point was mult_factor itself can be >= 2^32

> Anyway will drop the patch when I re-spin the series.
>

Are you re-spining just to change 24 to 32 in PATCH 3/3, if so no need.
I have already applied 1 and 3 here[1]. Just waiting for the builder
results to confirm it

--
Regards,
Sudeep

[1] https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/log/?h=for-next/scmi/updates