linux-kernel - Re: [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2845b899-efd8-49db-8ea6-18834e97071e@linuxfoundation.org>
Date:   Thu, 30 Nov 2023 13:25:37 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     angquan yu <angquan21@...il.com>
Cc:     shuah@...nel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests:proc: Resolve 'Unused Result' Warning from
 proc-empty-vm.c

On 11/28/23 20:45, angquan yu wrote:
> From: angquan yu <angquan21@...il.com>
> 
> In tools/testing/selftests/proc/proc-empty->because the return value
> of a write call was being ignored. This call was partof a conditional
> debugging block (if (0) { ... }), which meant it would neveractually
> execute.
> 
> This patch removes the unused debug write call. This cleanup resolves
> the compi>warning about ignoring the result of write declared with
> the warn_unused_resultattribute.
> 
> Removing this code also improves the clarity and maintainability of
> the function, as it eliminates a non-functional block of code.
> 
> This is original warning: proc-empty-vm.c: In function
> ‘test_proc_pid_statm’ :proc-empty-vm.c:385:17:
> warning: ignoring return value of ‘write’
> declared with>385 |                 write(1, buf, rv);|
> 
> Signed-off-by: angquan yu <angquan21@...il.com>
> ---
>   tools/testing/selftests/proc/proc-empty-vm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
> index 5e7020630..d231e61e4 100644
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> @@ -383,8 +383,10 @@ static int test_proc_pid_statm(pid_t pid)
>   	assert(rv <= sizeof(buf));
>   	if (0) {
>   		ssize_t written = write(1, buf, rv);
> +
>   		if (written == -1) {
>   			perror("write failed to /proc/${pid}");
> +			return EXIT_FAILURE;
>   		}
>   	}
>   

Hmm. Is this patch based on Linux 6.7-rc3? The code doesn't
match?

thanks,
-- Shuah