linux-kernel - Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8cef91eb-140c-46a6-b695-70df89bbdb81@app.fastmail.com>
Date:   Thu, 30 Nov 2023 22:36:50 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Andrew Morton" <akpm@...ux-foundation.org>
Cc:     "Stephen Rothwell" <sfr@...hwell.id.au>,
        linux-next <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "David S . Miller" <davem@...emloft.net>,
        sparclinux@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes
 addition

On Thu, Nov 30, 2023, at 17:19, Andrew Morton wrote:
> On Thu, 30 Nov 2023 09:07:38 +0100 "Arnd Bergmann" <arnd@...db.de> wrote:
>
>> > I guess it should precede "Makefile.extrawarn: turn on
>> > missing-prototypes globally".
>> 
>> I already have a collection of patches to fix up known
>> -Wmissing-prototype warnings across architectures in the
>> asm-generic tree, so I'll add this patch there:
>> 
>> commit bdef96eb0b89dfa80992312a8e3b2613bf178ae5
>> Author: Arnd Bergmann <arnd@...db.de>
>> Date:   Thu Nov 30 00:07:07 2023 +0100
>> 
>>     arch: turn off -Werror for architectures with known warnings
>
> I think this would be better in the mm-nonmm tree, alongside
> "Makefile.extrawarn: turn on missing-prototypes globally".  Can I steal it?

Agreed, that does help with bisection. I had pushed out the
asm-generic branch with the patch earlier today but now reverted
back to the previous state.

      Arnd