linux-kernel - Re: [PATCH] nvme-fc: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170138166766.3649510.14295562251346849867.b4-ty@chromium.org>
Date:   Thu, 30 Nov 2023 14:01:08 -0800
From:   Kees Cook <keescook@...omium.org>
To:     James Smart <james.smart@...adcom.com>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Justin Stitt <justinstitt@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] nvme-fc: replace deprecated strncpy with strscpy

On Thu, 19 Oct 2023 21:34:35 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> Let's instead use strscpy() [2] as it guarantees NUL-termination on the
> destination buffer.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] nvme-fc: replace deprecated strncpy with strscpy
      https://git.kernel.org/kees/c/f62cacf390b7

Take care,

-- 
Kees Cook