linux-kernel - Re: [PATCH v2] nvme: fix deadlock between reset and scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWkMfqF_VociudNB@kbusch-mbp.dhcp.thefacebook.com>
Date:   Thu, 30 Nov 2023 15:28:14 -0700
From:   Keith Busch <kbusch@...nel.org>
To:     Bitao Hu <yaoma@...ux.alibaba.com>
Cc:     sagi@...mberg.me, axboe@...nel.dk, hch@....de,
        kanie@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2] nvme: fix deadlock between reset and scan

On Thu, Nov 30, 2023 at 10:13:37AM +0800, Bitao Hu wrote:
> Fix by marking the ctrl with say NVME_CTRL_FROZEN flag set in
> nvme_start_freeze and cleared in nvme_unfreeze. Then the scan can check
> it before adding the new namespace (under the namespaces_rwsem).

Thanks for the detailed explanation. This looks good to me.

Reviewed-by: Keith Busch <kbsuch@...nel.org>