linux-kernel - Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWgBl07bJqrLTpzZ@casper.infradead.org>
Date:   Thu, 30 Nov 2023 03:29:27 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     zhiguojiang <justinjiang@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue

On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote:
> > > -		 * If kswapd scans pages marked for immediate
> > > +		 * If kswapd scans massive pages marked for immediate
> > I don't understand why you've added the word "massive".  Do you mean
> > that the pages are large, or that kswapd has scanned a lot of pages?
> The added "massive" means that there are a large number of pages marked for
> immediate reclaim on evictable LRUs.

Then the word "many" communicates your meaning better.  "massive" would
mean that each page is very big, while "many" means that there are a
lot of pages.

It was foolish to send out a v2 so swiftly.  Best wait for someone who's
familiar with this code to respond to it now that you've clarified what
you were doing.