linux-kernel - Re: [PATCH] highmem: fix a memory copy problem in memcpy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2023 04:15:22 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Su Hui <suhui@...china.com>
Cc:     nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com,
        akpm@...ux-foundation.org, fmdefrancesco@...il.com,
        ira.weiny@...el.com, tony.luck@...el.com, jiaqiyan@...gle.com,
        pcc@...gle.com, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] highmem: fix a memory copy problem in memcpy_from_folio

On Thu, Nov 30, 2023 at 11:40:18AM +0800, Su Hui wrote:
> Clang static checker complains that value stored to 'from' is never read.
> And memcpy_from_folio() only copy the last chunk memory from folio to
> destination.
> Using 'to += chunk' to replace 'from += chunk' to fix this typo problem.
> 
> Fixes: b23d03ef7af5 ("highmem: add memcpy_to_folio() and memcpy_from_folio()")
> Signed-off-by: Su Hui <suhui@...china.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>