linux-kernel - Re: [PATCH 1/2] dt-bindings: display: Add Sharp LS027B7DH01 Memory LCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dbdf7bd-cfa3-492b-a0a3-fdc323cf11f8@linaro.org>
Date:   Thu, 30 Nov 2023 09:38:23 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mehdi Djait <mehdi.djait@...tlin.com>, mripard@...nel.org,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        luca.ceresoli@...tlin.com, paul.kocialkowski@...tlin.com,
        dri-devel@...ts.freedesktop.org, geert@...ux-m68k.org
Subject: Re: [PATCH 1/2] dt-bindings: display: Add Sharp LS027B7DH01 Memory
 LCD

On 29/11/2023 15:29, Mehdi Djait wrote:
> +  pwms:
> +    maxItems: 1
> +    description: External COM inversion signal
> +
> +required:
> +  - compatible
> +  - reg
> +  - spi-lsb-first
> +  - enable-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +            #address-cells = <1>;

If there is going to be new version, then:
Use 4 spaces for example indentation.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof