linux-kernel - Re: [PATCH 1/2] drm/imagination: Fix error codes in pvr_device_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5a1e07ee366a547b389650bc7bb21ec81e00219.camel@imgtec.com>
Date:   Thu, 30 Nov 2023 09:09:26 +0000
From:   Frank Binns <Frank.Binns@...tec.com>
To:     "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
        Sarah Walker <Sarah.Walker@...tec.com>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        Donald Robson <Donald.Robson@...tec.com>,
        Matt Coster <Matt.Coster@...tec.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "mripard@...nel.org" <mripard@...nel.org>
Subject: Re: [PATCH 1/2] drm/imagination: Fix error codes in
 pvr_device_clk_init()

Hi,

Thank you for the patches.

On Thu, 2023-11-30 at 10:26 +0300, Dan Carpenter wrote:
> There is a cut and paste error so this code returns the wrong variable.
> 
> Fixes: 1f88f017e649 ("drm/imagination: Get GPU resources")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Frank Binns <frank.binns@...tec.com>

> ---
>  drivers/gpu/drm/imagination/pvr_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
> index 8499becf4fbb..e1dcc4e42087 100644
> --- a/drivers/gpu/drm/imagination/pvr_device.c
> +++ b/drivers/gpu/drm/imagination/pvr_device.c
> @@ -105,12 +105,12 @@ static int pvr_device_clk_init(struct pvr_device *pvr_dev)
>  
>  	sys_clk = devm_clk_get_optional(drm_dev->dev, "sys");
>  	if (IS_ERR(sys_clk))
> -		return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
> +		return dev_err_probe(drm_dev->dev, PTR_ERR(sys_clk),
>  				     "failed to get sys clock\n");
>  
>  	mem_clk = devm_clk_get_optional(drm_dev->dev, "mem");
>  	if (IS_ERR(mem_clk))
> -		return dev_err_probe(drm_dev->dev, PTR_ERR(core_clk),
> +		return dev_err_probe(drm_dev->dev, PTR_ERR(mem_clk),
>  				     "failed to get mem clock\n");
>  
>  	pvr_dev->core_clk = core_clk;