linux-kernel - Re: [PATCH -next] media: chips-media: Remove surplus dev_err() when using platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231130094951.dnhk6zy4zejgezxq@basti-XPS-13-9310>
Date:   Thu, 30 Nov 2023 10:49:51 +0100
From:   Sebastian Fricke <sebastian.fricke@...labora.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     mchehab@...nel.org, jackson.lee@...psnmedia.com,
        nas.chung@...psnmedia.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] media: chips-media: Remove surplus dev_err() when
 using platform_get_irq()

Hey Yang,

Thanks for the patch!

The commit subject line should point to the respective driver and you
can drop the brackets, so:
`media: chips-media: wave5: Remove surplus dev_err when using platform_get_irq`

Greetings,
Sebastian

On 27.11.2023 09:09, Yang Li wrote:
>There is no need to call the dev_err() function directly to print a
>custom message when handling an error from either the platform_get_irq()
>or platform_get_irq_byname() functions as both are going to display an
>appropriate error message in case of a failure.
>
>Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7636
>Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
>---
> drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
>index bfe4caa79cc9..3f7c622e8d58 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c
>@@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev)
>
> 	dev->irq = platform_get_irq(pdev, 0);
> 	if (dev->irq < 0) {
>-		dev_err(&pdev->dev, "failed to get irq resource\n");
> 		ret = -ENXIO;
> 		goto err_enc_unreg;
> 	}
>-- 
>2.20.1.7.g153144c
>
>