linux-kernel - drivers/crypto/starfive/jh7110-rsa.c:66:2-17: WARNING: NULL check before some freeing functions is not needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202311301702.LxswfETY-lkp@intel.com>
Date:   Thu, 30 Nov 2023 17:58:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jia Jie Ho <jiajie.ho@...rfivetech.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Huan Feng <huan.feng@...rfivetech.com>
Subject: drivers/crypto/starfive/jh7110-rsa.c:66:2-17: WARNING: NULL check
 before some freeing functions is not needed.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3b47bc037bd44f142ac09848e8d3ecccc726be99
commit: 445a4aaf5842073e4130b1d6dbe3785284d9615f crypto: starfive - Add RSA algo support
date:   5 months ago
config: arm64-randconfig-r061-20231130 (https://download.01.org/0day-ci/archive/20231130/202311301702.LxswfETY-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231130/202311301702.LxswfETY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311301702.LxswfETY-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/starfive/jh7110-rsa.c:66:2-17: WARNING: NULL check before some freeing functions is not needed.
   drivers/crypto/starfive/jh7110-rsa.c:68:2-17: WARNING: NULL check before some freeing functions is not needed.
   drivers/crypto/starfive/jh7110-rsa.c:70:2-17: WARNING: NULL check before some freeing functions is not needed.

vim +66 drivers/crypto/starfive/jh7110-rsa.c

    62	
    63	static void starfive_rsa_free_key(struct starfive_rsa_key *key)
    64	{
    65		if (key->d)
  > 66			kfree_sensitive(key->d);
    67		if (key->e)
    68			kfree_sensitive(key->e);
    69		if (key->n)
    70			kfree_sensitive(key->n);
    71		memset(key, 0, sizeof(*key));
    72	}
    73	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki