lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 29 Nov 2023 16:06:38 -0800
From:   Rahul Rameshbabu <>
To:     Jakub Kicinski <>
Cc:     Köry Maincent <>,
        Vladimir Oltean <>,
        Andrew Lunn <>,
        Florian Fainelli <>,
        Broadcom internal kernel review list 
        Heiner Kallweit <>,
        Russell King <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Paolo Abeni <>,
        Richard Cochran <>,
        Radu Pirea <>,
        Jay Vosburgh <>,
        Andy Gospodarek <>,
        Nicolas Ferre <>,
        Claudiu Beznea <>,
        Willem de Bruijn <>,
        Jonathan Corbet <>,
        Horatiu Vultur <>,, Simon Horman <>,
        Thomas Petazzoni <>,,,,
        Maxime Chevallier <>
Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time
 stamping layer be selectable

On Wed, 29 Nov, 2023 15:56:13 -0800 Jakub Kicinski <> wrote:
> On Wed, 29 Nov 2023 23:00:34 +0100 Köry Maincent wrote:
>> > Not sure why you say "not used", though. Are you not planning to expose
>> > the qualifier as an attribute to the listing of hwtstamp providers
>> > offered to user space by ETHTOOL_MSG_TSINFO_GET?  
>> Yes I will, I was just saying that all the PHC would be set as precise for now.
>> Approximate timestamp quality won't be used because IIUC there are no NIC driver
>> supporting it yet.
> Agreed that we should add the attr from the start.
> Maybe we can ask/work with Rahul <>
> to implement the right thing in mlx5?

Thanks for looping me in. We were already looking at this patch series
out of interest. I saw your suggestion to rephrase "MAC / DMA" as
"precise / approximate", which we really like for mlx5 devices because
our "approximate" timestamping logic is not exactly a "MAC" timestamp
but its not a port timestamp that has the greater precision we use. I
have a task already for implementing support for this ethtool attribute.
If folks here are open to it, I can add mlx5 support for both modes in
this patch series for the next revision that will entail the discussed

> Failing that we can mark mlx5 as imprecise, until its sorted out.
> So that we have both types in the tree.


Rahul Rameshbabu

Powered by blists - more mailing lists