linux-kernel - Re: [PATCH] bpf/tests: Remove duplicate JSGT tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2023 12:06:47 +0100
From:   Johan Almbladh <johan.almbladh@...finetworks.com>
To:     Yujie Liu <yujie.liu@...el.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf/tests: Remove duplicate JSGT tests

On Thu, Nov 30, 2023 at 4:44 AM Yujie Liu <yujie.liu@...el.com> wrote:
>
> It seems unnecessary that JSGT is tested twice (one before JSGE and one
> after JSGE) since others are tested only once. Remove the duplicate JSGT
> tests.

Looks like a copy-paste typo on my side. Thanks!

Acked-by: Johan Almbladh <johan.almbladh@...finetworks.com>

>
> Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
> Signed-off-by: Yujie Liu <yujie.liu@...el.com>
> ---
>  lib/test_bpf.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index 7916503e6a6a..87a4ebcc65be 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -12215,7 +12215,6 @@ static struct bpf_test tests[] = {
>         BPF_JMP32_IMM_ZEXT(JLE),
>         BPF_JMP32_IMM_ZEXT(JSGT),
>         BPF_JMP32_IMM_ZEXT(JSGE),
> -       BPF_JMP32_IMM_ZEXT(JSGT),
>         BPF_JMP32_IMM_ZEXT(JSLT),
>         BPF_JMP32_IMM_ZEXT(JSLE),
>  #undef BPF_JMP2_IMM_ZEXT
> @@ -12251,7 +12250,6 @@ static struct bpf_test tests[] = {
>         BPF_JMP32_REG_ZEXT(JLE),
>         BPF_JMP32_REG_ZEXT(JSGT),
>         BPF_JMP32_REG_ZEXT(JSGE),
> -       BPF_JMP32_REG_ZEXT(JSGT),
>         BPF_JMP32_REG_ZEXT(JSLT),
>         BPF_JMP32_REG_ZEXT(JSLE),
>  #undef BPF_JMP2_REG_ZEXT
> --
> 2.34.1
>