linux-kernel - Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2023 19:15:44 +0800
From:   Jinlong Mao <quic_jinlmao@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Tao Zhang <quic_taozha@...cinc.com>
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a
 required property



On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
> On 29/11/2023 15:38, Mao Jinlong wrote:
>> The inport of funnel@...3000 connects to a source which is not supported
>> in current linux kernel. Remove the device tree node of funnel@...3000
>> to fix the warning. It will be added once the driver support to the
>> source is added to linux kernel.
> 
> Thanks for the changes, but that's not correct reason to remove DTS
> code. What kernel supports or not, should be irrelevant for the DTS. DTS
> for example is used in other projects - did you check if they have the
> same issues? Anyway, DTS describes the hardware, so how current kernel
> support defines what is and what is not in the hardware?
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

The funnel dt node must have in-ports node. It is to describe the input
connection of funnel HW. But there is no dt_binding doc to describe the
DT node of the HW connected to funnel@...3000. So remove the funnel to 
solve the warning as of now. The funnel will be added back once driver 
and dt_binding are added for the HW.

Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

Thanks
Jinlong Mao
>