linux-kernel - Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20231130112130.GH1470173@google.com>
Date:   Thu, 30 Nov 2023 11:21:30 +0000
From:   Lee Jones <lee@...nel.org>
To:     GaryWang 汪之逸 <GaryWang@...on.com.tw>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "larry.lai" <larry.lai@...jingtech.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "pavel@....cz" <pavel@....cz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "musa.lin@...jingtech.com" <musa.lin@...jingtech.com>,
        "jack.chang@...jingtech.com" <jack.chang@...jingtech.com>,
        "noah.hung@...jingtech.com" <noah.hung@...jingtech.com>
Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board
 CPLD/FPGA

On Thu, 30 Nov 2023, GaryWang 汪之逸 wrote:

> All,
>         Reply again to plain text format & line-warp and trim agree part as Jones's suggestion,
>         please let me know if there are still having format issue.
>         please kindly to check our comments with ">>" beginning.

This is still incorrect.

Please fix your mail client, or use a different one.

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Tuesday, November 14, 2023 10:19 PM
> To: larry.lai <larry.lai@...jingtech.com>
> Cc: lee@...nel.org; linus.walleij@...aro.org; pavel@....cz; linux-kernel@...r.kernel.org; linux-gpio@...r.kernel.org; linux-leds@...r.kernel.org; GaryWang 汪之逸 <GaryWang@...on.com.tw>; musa.lin@...jingtech.com; jack.chang@...jingtech.com; noah.hung@...jingtech.com
> Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

Why is your client putting headers in the body?

> On Tue, Oct 31, 2023 at 09:51:18AM +0800, larry.lai wrote:
> > The UP Squared board
> > <http://www.upboard.com/> implements certain features (pin control) through an on-board FPGA.
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Gary Wang <garywang@...on.com.tw>
> > Signed-off-by: larry.lai <larry.lai@...jingtech.com>
> 
> 
> 
> > +#include "intel/pinctrl-intel.h"
> 
> I do not think it's correct use of the header.
> >> see below

No, this should look like this:

>  <Thing you're replying to here>

[Your response here]

Please fix the client to quote properly and drop the confusing ">>" stuff.

> ...

Make snips clearer please, either:

  [...]

Or:

  [SNIP]

[...]

-- 
Lee Jones [李琼斯]