linux-kernel - Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2023 13:05:08 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org,
        monstr@...str.eu, michal.simek@...inx.com, git@...inx.com
Cc:     Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Parth Gajjar <parth.gajjar@....com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Varalaxmi Bingi <varalaxmi.bingi@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible

On 30/11/2023 11:02, Michal Simek wrote:
> 
> 
> On 11/30/23 10:29, Krzysztof Kozlowski wrote:
>> On 30/11/2023 10:19, Michal Simek wrote:
>>> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox
>>> compatible") make compatible string for child nodes mandatory that's why
>>> add it.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@....com>
>>> ---
>>>
>>>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> index f5e1eb8cb3b7..eaba466804bc 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi {
>>>   
>>>   		ipi_mailbox_pmu1: mailbox@...905c0 {
>>>   			bootph-all;
>>> +			compatible = "xlnx,zynqmp-ipi-dest-mailbox";
>>
>> Probably you want it as first property. Although then reg is also placed
>> odd, but it's all because bootph-all was put at the beginning.
> 
> When DTS conding style is approved I will need to resort all that nodes based on 
> it. I did this change to be aligned with current style which this file has.
> What do you think?

Hm, indeed. So it is entirely up to you :)

Best regards,
Krzysztof