lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f20c8c30-1379-4706-b980-73d2f7e5912a@arm.com>
Date:   Thu, 30 Nov 2023 12:53:30 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     hongyan.xia2@....com, mingo@...hat.com, alexs@...nel.org,
        linux-kernel@...r.kernel.org, vschneid@...hat.com,
        bristot@...hat.com, bsegall@...gle.com, rostedt@...dmis.org,
        dietmar.eggemann@....com, peterz@...radead.org,
        juri.lelli@...hat.com, mgorman@...e.de, corbet@....net,
        siyanteng@...ngson.cn, qyousef@...alina.io,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH 0/2] Simplify Util_est

Hi Vincent,

On 11/27/23 14:32, Vincent Guittot wrote:
> Following comment in [1], I prepared a patch to remove UTIL_EST_FASTUP.
> This enables us to simplify util_est behavior as proposed in patch 2.
> 
> [1] https://lore.kernel.org/lkml/CAKfTPtCAZWp7tRgTpwJmyEAkyN65acmYrfu9naEUpBZVWNTcQA@mail.gmail.com/
> 
> Vincent Guittot (2):
>    sched/fair: Remove SCHED_FEAT(UTIL_EST_FASTUP, true)
>    sched/fair: Simplify util_est
> 
>   Documentation/scheduler/schedutil.rst |  7 +--
>   include/linux/sched.h                 | 35 ++----------
>   kernel/sched/debug.c                  |  7 +--
>   kernel/sched/fair.c                   | 81 ++++++++++-----------------
>   kernel/sched/features.h               |  1 -
>   kernel/sched/pelt.h                   |  4 +-
>   6 files changed, 43 insertions(+), 92 deletions(-)
> 

I recovered my pixel6 and applied these changes.
No power regression in Jankbench. No performance regression in GB5.
Better score in Chrome running Speedometer +3..5%.

The code looks much more clean, without the 'struct util_est'
(we will have to adjust our trace events to that change but it's worth).

Also, I was a bit surprised that the UTIL_EST_FASTUP wasn't helping
that much comparing to that new 'runnable' signal for the
underestimation corner case...

Reviewed-and-tested-by: Lukasz Luba <lukasz.luba@....com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ