| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZWiaB+ygpN+46JAm@kernel.org>
Date: Thu, 30 Nov 2023 11:19:51 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Nick Terrell <terrelln@...com>,
Kan Liang <kan.liang@...ux.intel.com>,
Andi Kleen <ak@...ux.intel.com>,
Kajol Jain <kjain@...ux.ibm.com>,
Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
Huacai Chen <chenhuacai@...nel.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
Vincent Whitchurch <vincent.whitchurch@...s.com>,
"Steinar H. Gunderson" <sesse@...gle.com>,
Liam Howlett <liam.howlett@...cle.com>,
Miguel Ojeda <ojeda@...nel.org>,
Colin Ian King <colin.i.king@...il.com>,
Dmitrii Dolgov <9erthalion6@...il.com>,
Yang Jihong <yangjihong1@...wei.com>,
Ming Wang <wangming01@...ngson.cn>,
James Clark <james.clark@....com>,
K Prateek Nayak <kprateek.nayak@....com>,
Sean Christopherson <seanjc@...gle.com>,
Leo Yan <leo.yan@...aro.org>,
Ravi Bangoria <ravi.bangoria@....com>,
German Gomez <german.gomez@....com>,
Changbin Du <changbin.du@...wei.com>,
Paolo Bonzini <pbonzini@...hat.com>, Li Dong <lidong@...o.com>,
Sandipan Das <sandipan.das@....com>,
liuwenyu <liuwenyu7@...wei.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org,
Guilherme Amadio <amadio@...too.org>
Subject: Re: [PATCH v5 02/50] libperf: Lazily allocate/size mmap event copy
Em Thu, Nov 30, 2023 at 10:15:43AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Nov 27, 2023 at 02:08:14PM -0800, Ian Rogers escreveu:
> > void perf_mmap__munmap(struct perf_mmap *map)
> > {
> > - if (map && map->base != NULL) {
> > + if (!map)
> > + return;
> > +
> > + free(map->event_copy);
> > + map->event_copy = NULL;
>
> I´m converting this to:
>
> zfree(&map->event_copy);
>
> Hopefully we'll find some tool to flag these before submitting patches,
> does clang-tidy do these kinds of things?
>
> Also, applied:
>
> b4 am -P2,4-7 -ctsl --cc-trailers 20231127220902.1315692-1-irogers@...gle.com
>
> The ones that Namhyung acked and that applied cleanly in order.
>
> The first one, as Namhyung noted, is already merged.
I'll fix this later:
[perfbuilder@...e ~]$ export BUILD_TARBALL=http://192.168.86.5/perf/perf-6.6.0-rc1.tar.xz
[perfbuilder@...e ~]$ time dm
1 16.97 almalinux:8 : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-20) (GCC)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
INSTALL libbpf_headers
INSTALL libperf_headers
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libperf/include/perf/event.h
CC /tmp/build/perf/libperf/mmap.o
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_legacy.h
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_helpers.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
INSTALL /tmp/build/perf/libperf/include/perf/mmap.h
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_tracing.h
CC /tmp/build/perf/libperf/zalloc.o
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_endian.h
2 17.28 almalinux:9 : FAIL gcc version 11.4.1 20230605 (Red Hat 11.4.1-2) (GCC)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
INSTALL libperf_headers
INSTALL libbpf_headers
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libperf/include/perf/evlist.h
INSTALL /tmp/build/perf/libperf/include/perf/evsel.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_legacy.h
INSTALL /tmp/build/perf/libperf/include/perf/event.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_helpers.h
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_tracing.h
INSTALL /tmp/build/perf/libperf/include/perf/mmap.h
CC /tmp/build/perf/libperf/evlist.o
3 20.71 alpine:3.15 : FAIL gcc version 10.3.1 20211027 (Alpine 10.3.1_git20211027)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
CC /tmp/build/perf/libperf/xyarray.o
CC /tmp/build/perf/libperf/lib.o
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v0.so
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v2.so
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[5]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:106: /tmp/build/perf/libapi/fs/fs.o] Error 1
make[5]: *** Waiting for unfinished jobs....
LD /tmp/build/perf/libapi/fd/libapi-in.o
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
4 20.52 alpine:3.16 : FAIL gcc version 11.2.1 20220219 (Alpine 11.2.1_git20220219)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v2.so
CC /tmp/build/perf/libperf/xyarray.o
INSTALL libperf_headers
CC /tmp/build/perf/libperf/lib.o
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[5]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:106: /tmp/build/perf/libapi/fs/fs.o] Error 1
make[5]: *** Waiting for unfinished jobs....
LD /tmp/build/perf/libapi/fd/libapi-in.o
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
5 19.77 alpine:3.17 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r4)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
INSTALL libperf_headers
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libperf/include/internal/threadmap.h
CC /tmp/build/perf/libperf/xyarray.o
CC /tmp/build/perf/libperf/lib.o
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v0.so
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v2.so
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
INSTALL /tmp/build/perf/libperf/include/internal/xyarray.h
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
6 17.79 alpine:3.18 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_core_read.h
INSTALL /tmp/build/perf/libbpf/include/bpf/skel_internal.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[5]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:106: /tmp/build/perf/libapi/fs/fs.o] Error 1
make[5]: *** Waiting for unfinished jobs....
LD /tmp/build/perf/libapi/fd/libapi-in.o
LD /tmp/build/perf/libsymbol/libsymbol-in.o
7 19.74 alpine:edge : FAIL gcc version 13.1.1 20230722 (Alpine 13.1.1_git20230722)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
CC /tmp/build/perf/libperf/zalloc.o
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf.h
CC /tmp/build/perf/libperf/xyarray.o
CC /tmp/build/perf/libperf/lib.o
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
LINK /tmp/build/perf/dlfilters/dlfilter-show-cycles.so
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v0.so
LINK /tmp/build/perf/dlfilters/dlfilter-test-api-v2.so
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf.h
8 11.61 amazonlinux:2 : FAIL gcc version 7.3.1 20180712 (Red Hat 7.3.1-17) (GCC)
In file included from fs/fs.c:19:0:
fs/../io.h:94:46: error: unknown type name '__u64'; did you mean '_LP64'?
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
_LP64
fs/../io.h:123:46: error: unknown type name '__u64'; did you mean '_LP64'?
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
_LP64
INSTALL libapi_headers
INSTALL libsymbol_headers
make[4]: *** [fs] Error 2
CC /tmp/build/perf/libsubcmd/subcmd-config.o
GEN /tmp/build/perf/libbpf/bpf_helper_defs.h
INSTALL /tmp/build/perf/libperf/include/perf/cpumap.h
CC /tmp/build/perf/libperf/cpumap.o
In file included from fs/fs.c:19:0:
fs/../io.h:94:46: error: unknown type name '__u64'; did you mean '_LP64'?
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
_LP64
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf.h
fs/../io.h:123:46: error: unknown type name '__u64'; did you mean '_LP64'?
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
_LP64
INSTALL /tmp/build/perf/libperf/include/perf/threadmap.h
9 12.89 amazonlinux:2023 : FAIL gcc version 11.4.1 20230605 (Red Hat 11.4.1-2) (GCC)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_core_read.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
INSTALL /tmp/build/perf/libbpf/include/bpf/skel_internal.h
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[5]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:106: /tmp/build/perf/libapi/fs/fs.o] Error 1
make[5]: *** Waiting for unfinished jobs....
LD /tmp/build/perf/libapi/fd/libapi-in.o
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
10 12.84 amazonlinux:devel : FAIL gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
CC /tmp/build/perf/libperf/lib.o
INSTALL /tmp/build/perf/libbpf/include/bpf/skel_internal.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
make[5]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:106: /tmp/build/perf/libapi/fs/fs.o] Error 1
make[5]: *** Waiting for unfinished jobs....
LD /tmp/build/perf/libapi/fd/libapi-in.o
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
11 147.52 archlinux:base : Ok gcc (GCC) 13.2.1 20230801 , clang version 16.0.6 flex 2.6.4
12 13.41 centos:stream : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-21) (GCC)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_tracing.h
CC /tmp/build/perf/libperf/xyarray.o
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_endian.h
CC /tmp/build/perf/libperf/lib.o
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_core_read.h
INSTALL /tmp/build/perf/libbpf/include/bpf/skel_internal.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
13 108.26 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 13.2.1 20231115 releases/gcc-13.2.0-463-g5d6f62c9b2 , clang version 16.0.6 flex 2.6.4
14 10.87 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
INSTALL libbpf_headers
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_tracing.h
CC /tmp/build/perf/libapi/cpu.o
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_endian.h
INSTALL /tmp/build/perf/libbpf/include/bpf/bpf_core_read.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
static inline int io__get_hex(struct io *io, __u64 *hex)
^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
static inline int io__get_dec(struct io *io, __u64 *dec)
^~~~~
INSTALL /tmp/build/perf/libbpf/include/bpf/skel_internal.h
INSTALL /tmp/build/perf/libbpf/include/bpf/libbpf_version.h
CC /tmp/build/perf/libapi/debug.o
CC /tmp/build/perf/libapi/str_error_r.o
15 12.70 debian:11 : FAIL gcc version 10.2.1 20210110 (Debian 10.2.1-6)
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
INSTALL libperf_headers
make[4]: *** [/git/perf-6.6.0-rc1/tools/build/Makefile.build:158: fs] Error 2
INSTALL /tmp/build/perf/libbpf/include/bpf/usdt.bpf.h
INSTALL /tmp/build/perf/libperf/include/internal/cpumap.h
INSTALL /tmp/build/perf/libperf/include/internal/evlist.h
INSTALL /tmp/build/perf/libperf/include/internal/evsel.h
In file included from fs/fs.c:19:
fs/../io.h:94:46: error: unknown type name '__u64'
94 | static inline int io__get_hex(struct io *io, __u64 *hex)
| ^~~~~
fs/../io.h:123:46: error: unknown type name '__u64'
123 | static inline int io__get_dec(struct io *io, __u64 *dec)
| ^~~~~
CC /tmp/build/perf/libperf/zalloc.o
INSTALL /tmp/build/perf/libperf/include/internal/lib.h
INSTALL /tmp/build/perf/libperf/include/internal/mmap.h
CC /tmp/build/perf/libperf/xyarray.o
16 85.50 debian:12 : Ok gcc (Debian 12.2.0-14) 12.2.0 , Debian clang version 14.0.6 flex 2.6.4
17: debian:experimental
Powered by blists - more mailing lists